[ACM-16286/backport 2.12]: Ensure MCO spec addon options are propagated correctly #1725
Conversation
…tolostron#1718) * [ACM-16286]: Ensure MCO spec addon options are propagated correctly Signed-off-by: Saswata Mukherjee <[email protected]> * [ACM-16286]: Update all observabilityaddon manifests Signed-off-by: Saswata Mukherjee <[email protected]> * [ACM-16286]: Ensure hub and spoke obsaddon are synced based on spec Signed-off-by: Saswata Mukherjee <[email protected]> * [ACM-16286]: Allow customizing ObsAddon in spoke ns Signed-off-by: Saswata Mukherjee <[email protected]> * [ACM-16286]: Comments Signed-off-by: Saswata Mukherjee <[email protected]> * Add addon source annotation Signed-off-by: Saswata Mukherjee <[email protected]> * Add handling for empty map Signed-off-by: Saswata Mukherjee <[email protected]> * Add handling for nil maps Signed-off-by: Saswata Mukherjee <[email protected]> * Add annotation predicate, update in mco mode Signed-off-by: Saswata Mukherjee <[email protected]> * Fix unit test, make addon annotation constant Signed-off-by: Saswata Mukherjee <[email protected]> * Update comment Signed-off-by: Saswata Mukherjee <[email protected]> * Address comments Signed-off-by: Saswata Mukherjee <[email protected]> * Use semantic deepequal, add test for setter Signed-off-by: Saswata Mukherjee <[email protected]> * Set spoke addon correctly after comparison Signed-off-by: Saswata Mukherjee <[email protected]> --------- Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coleenquadros, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
|
@saswatamcode: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…#1718)
ACM-16286: Ensure MCO spec addon options are propagated correctly
ACM-16286: Update all observabilityaddon manifests
ACM-16286: Ensure hub and spoke obsaddon are synced based on spec
ACM-16286: Allow customizing ObsAddon in spoke ns
Add addon source annotation
Add handling for empty map
Add handling for nil maps
Add annotation predicate, update in mco mode
Fix unit test, make addon annotation constant
Update comment
Address comments
Use semantic deepequal, add test for setter
Set spoke addon correctly after comparison